Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regression: remove unnecessary log on notifyUsersOnMessage #33207

Merged
merged 1 commit into from
Sep 4, 2024
Merged

regression: remove unnecessary log on notifyUsersOnMessage #33207

merged 1 commit into from
Sep 4, 2024

Conversation

ricardogarim
Copy link
Contributor

This PR removes an unnecessary console.log that was displaying on the server every time a message was sent.

@dionisio-bot dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Sep 4, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 4, 2024

⚠️ No Changeset found

Latest commit: dc6be3a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ggazzo ggazzo changed the title chore: remove unnecessary log on notifyUsersOnMessage regression: remove unnecessary log on notifyUsersOnMessage Sep 4, 2024
@ggazzo ggazzo marked this pull request as ready for review September 4, 2024 12:33
@ggazzo ggazzo merged commit 3ba1854 into develop Sep 4, 2024
13 of 14 checks passed
@ggazzo ggazzo deleted the chore/remove-unneeded-log branch September 4, 2024 12:33
@ggazzo ggazzo added this to the 6.12 milestone Sep 4, 2024
ggazzo pushed a commit that referenced this pull request Sep 4, 2024
@ricardogarim @ggazzo
regression: remove unnecessary log on notifyUsersOnMessage (#33207)
e12661a
@codecov Codecov
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.31%. Comparing base (200d22b) to head (dc6be3a).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33207   +/-   ##
========================================
  Coverage    59.31%   59.31%           
========================================
  Files         2547     2547           
  Lines        63343    63343           
  Branches     14252    14252           
========================================
  Hits         37570    37570           
  Misses       23070    23070           
  Partials      2703     2703
Flag Coverage Δ
unit 75.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

abhinavkrin pushed a commit that referenced this pull request Oct 25, 2024
@ricardogarim @abhinavkrin
regression: remove unnecessary log on notifyUsersOnMessage (#33207)
ba72a41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggazzo ggazzo ggazzo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.12
Development

Successfully merging this pull request may close these issues.
2 participants
@ricardogarim @ggazzo