-
Notifications
You must be signed in to change notification settings - Fork 12
Installation #5
Comments
It seems that the compiler cannot find your pytorch. Can you compile any other c++ extension of torch? Like the one in torch/test This extension should just work by running |
Did you mean if $ find . -iname "optional.h"
./c10/util/Optional.h
./torch/lib/tmp_install/include/c10/util/Optional.h
./torch/lib/include/c10/util/Optional.h
./build/lib.linux-x86_64-3.6/torch/lib/include/c10/util/Optional.h
./third_party/ideep/tests/rapidcheck/extras/boost/include/rapidcheck/gen/boost/Optional.h |
It seems this file is changed in 1.0, I'm trying this in latest 1.0. I can compile it with 0.4 tho. I'll try update the name conventions. sorry. Maybe you could try this branch: |
@boeddeker I guess @ezyang just fixed the compilation with pytorch 1.0, let us know if you can compile it now. |
Thanks, now I can compile it. |
Hi, tried installing with pytorch version 1.0.0a0. Got this error when using python setup.py install: Any suggestions? Thanks |
I'm not sure exactly what pytorch version is 1.0.0a0, but you're going to need master for pytorch-complex |
with fixes from #6, i get this upon
related to pytorch/pytorch#15105? |
Could you show me the full error msg? I didn't see the rest of the error. I guess there should be some error message address which kind of error is this. |
|
Using fix#6 and running python setup.py install . Got the error below, what do you think? running install |
you can try to find the missing file with |
I have the exact same compilation issue as ItaiWisense. Arsenovic, I am not sure how to get to General.h or exactly what you mean by modifying the includes. I just made a Virtualenv on ubuntu for windows and downloaded the most recent version of torch and torchvision. If anyone has any suggestions, I'd much appreciate it. Thank you. |
the error from @ItaiWisense looks just like a missing header, which i had at first also. so you just need to modify the |
hi, @Roger-luo Trying out your package. However, I get this error when installing on Macbook pro and our compute cluster
|
I'll take a pass and update the includes for master this weekend. In the future, we should advertise a specific commit hash of PyTorch or nightly which this extension is known to work with. |
@ezyang Maybe we should have a fork or a branch for now, which will make this extension work temporarily to try it out? I've updated this extension for several times as well, sometimes it's hard to notice patches in the main tree will cause this extension fail. I only got one alert once... |
Yes, we could do that too. There's so much stuff changing on master it's hard to keep up otherwise. It's a little bit of a shame because the extension can be used with a stock build of PyTorch... but only a very specific stock build :) |
why not just make a tag release and set the dependencies to the proper pytorch version? Is the master version no compilable? |
As what's README says, this package is work in progress and requires some patches in the main tree in the future. There's no proper release of pytorch for this extension yet. |
That’s cool, I saw that. I guess I was more wondering if you guys pushed the header fixes so we can build. |
I pushed an update for latest master just now. Give it a try. |
Huh, I've never seen that one before. What compiler are you compiling with? |
ok, just rebuilt pytorch (to the hash listed), and I'm still getting the following compile error:
|
There is something wrong with your C++ installation:
|
ok sad... haha. This probably has something to do with Xcode and Mojave. Any suggestions on what to google or how to fix? |
Fixed... For anyone else with this issue: This is a Mac Mojave specific issue where the latest XCode changes the compiler defaults. To fix:
to
See #7 |
Hi, I encountered the same problem. Have you fixed it? |
@Zellar209 yes, if you are using the specific commit in README, this should be fixed. |
The remained problem for this issue is something related to pytorch/pytorch#16805 on MacOS. Have no clue on this yet. |
I fixed the problem by changing |
@Zellar209 what's your OS? MacOS or Linux? |
@Zellar209 What's your pytorch version? and what's your clang version? Could you post these reports here? The original issue #755 is not quite related and already pretty long to read. |
@Roger-luo I am not @Zellar209 but maybe I can answer:
|
I am usingMacOS 14.04 torch.version clang version 4.0.1 (tags/RELEASE_401/final) Thank you very much. |
@Zellar209 could you checkout to this commit @Haydnspass yes, I noticed that with some Xcode (even on my own laptop), even the pytorch's cpp extension test won't pass (torch itself is fine...). I'm sure there's some problem with Xcode... but I haven't figured out what's the problem and how to fix it. But @Zellar209 's errors seems to be that he is not using the correct commit. And please notice, this package is far from practical usage, so please do not use this in practical code. It probably give you the wrong results due to its lack of test and functionality. |
I am interested in complex support for pytorch. I want to translate our Complex differentable operations from Chainer to Pytorch. But I am not familiar with C++.
Can you provide more information, how this complex extension for pytorch can be installed?
I have installed pytorch from git (1.0.0a0+4574ea3) and get the error msg
when I run
python setup.py install
.The text was updated successfully, but these errors were encountered: