fix: Incomplete Ready, DownloadUsersAsync, and optimize AlwaysDownloadUsers #1548
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There were three issues related to how these were being done:
guild_id
s (tested up to 200, but limited to 100 since it isn't documented).count
inDownloadUsersAsync
, returning a negative number.Changes
MaxWaitBetweenGuildAvailablesBeforeReady
toDiscordSocketConfig
that will let the user decide how long they want to wait, zero being an option (firing READY without waiting GUILD_AVAILABLEs).Request Guild Members
gateway request (tested up to 200 and it still worked fine).count
is calculated inDownloadUsersAsync