Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Performance dropping when moving multiple nodes #166

Open
l3enQ opened this issue Jan 20, 2024 · 2 comments
Open

[BUG]: Performance dropping when moving multiple nodes #166

l3enQ opened this issue Jan 20, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@l3enQ
Copy link
Contributor

l3enQ commented Jan 20, 2024

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Software Versions
Application version: (add either official git release version or git SHA)
Firmware version: (add either official git release version or git SHA)

Additional context
Add any other context about the problem here.

@l3enQ l3enQ added the bug Something isn't working label Jan 20, 2024
@HamedMasafi
Copy link
Contributor

I checked and saw that in the mouse movement event, the position relative to the last point is saved, which can cause lag. I changed this routine to coordinates relative to the click point.

https://github.com/Roniasoft/NodeLink/blob/wip/movement_speed/resources/View/ObjectSelectionView.qml#L106

https://github.com/Roniasoft/NodeLink/blob/wip/movement_speed/resources/View/ObjectSelectionView.qml#L130

Also, I added a flag in the bottom line so that PortView.qml::opacity properties do not change when the Nodes are moving.

https://github.com/Roniasoft/NodeLink/blob/wip/movement_speed/resources/View/PortView.qml#L39

My changes are available on the movement_speed branch. I would be grateful if someone could test them.

@HamedMasafi
Copy link
Contributor

Memory managment checked; There's no memory leak. Nodes destroy correctly after deleting from scene but I found that some function in I_Scene.qml can be written in better way. I'll send a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants