fix: refresh models button not flushing cache properly (#9870)

Author: pdecat

src/__tests__/extension.spec.ts

@@ -384,7 +384,7 @@ describe("extension.ts", () => {
 			})
 
 			// Verify flushModels was called to clear the cache on logout
-			expect(flushModels).toHaveBeenCalledWith("roo", false)
+			expect(flushModels).toHaveBeenCalledWith({ provider: "roo" }, false)
 		})
 	})
 })

src/api/providers/__tests__/deepinfra.spec.ts

@@ -26,6 +26,7 @@ vitest.mock("../fetchers/modelCache", () => ({
 	getModels: vitest.fn().mockResolvedValue({
 		[deepInfraDefaultModelId]: deepInfraDefaultModelInfo,
 	}),
+	getModelsFromCache: vitest.fn().mockReturnValue(undefined),
 }))
 
 import OpenAI from "openai"

src/api/providers/__tests__/lite-llm.spec.ts

@@ -42,6 +42,7 @@ vi.mock("../fetchers/modelCache", () => ({
 			"gpt-4-turbo": { ...litellmDefaultModelInfo, maxTokens: 8192 },
 		})
 	}),
+	getModelsFromCache: vi.fn().mockReturnValue(undefined),
 }))
 
 describe("LiteLLMHandler", () => {

src/api/providers/__tests__/unbound.spec.ts

@@ -71,6 +71,7 @@ vitest.mock("../fetchers/modelCache", () => ({
 			},
 		})
 	}),
+	getModelsFromCache: vitest.fn().mockReturnValue(undefined),
 }))
 
 // Mock OpenAI client

src/api/providers/__tests__/vercel-ai-gateway.spec.ts

@@ -51,6 +51,7 @@ vitest.mock("../fetchers/modelCache", () => ({
 			},
 		})
 	}),
+	getModelsFromCache: vitest.fn().mockReturnValue(undefined),
 }))
 
 vitest.mock("../../transform/caching/vercel-ai-gateway", () => ({

src/api/providers/fetchers/lmstudio.ts

@@ -19,7 +19,7 @@ export const forceFullModelDetailsLoad = async (baseUrl: string, modelId: string
 		const client = new LMStudioClient({ baseUrl: lmsUrl })
 		await client.llm.model(modelId)
 		// Flush and refresh cache to get updated model details
-		await flushModels("lmstudio", true)
+		await flushModels({ provider: "lmstudio", baseUrl }, true)
 
 		// Mark this model as having full details loaded.
 		modelsWithLoadedDetails.add(modelId)

src/api/providers/fetchers/modelCache.ts

@@ -267,20 +267,20 @@ export async function initializeModelCacheRefresh(): Promise<void> {
 /**
  * Flush models memory cache for a specific router.
  *
- * @param router - The router to flush models for.
+ * @param options - The options for fetching models, including provider, apiKey, and baseUrl
  * @param refresh - If true, immediately fetch fresh data from API
  */
-export const flushModels = async (router: RouterName, refresh: boolean = false): Promise<void> => {
+export const flushModels = async (options: GetModelsOptions, refresh: boolean = false): Promise<void> => {
+	const { provider } = options
 	if (refresh) {
 		// Don't delete memory cache - let refreshModels atomically replace it
 		// This prevents a race condition where getModels() might be called
 		// before refresh completes, avoiding a gap in cache availability
-		refreshModels({ provider: router } as GetModelsOptions).catch((error) => {
-			console.error(`[flushModels] Refresh failed for ${router}:`, error)
-		})
+		// Await the refresh to ensure the cache is updated before returning
+		await refreshModels(options)
 	} else {
 		// Only delete memory cache when not refreshing
-		memoryCache.del(router)
+		memoryCache.del(provider)
 	}
 }
 

src/api/providers/router-provider.ts

@@ -5,7 +5,7 @@ import type { ModelInfo } from "@roo-code/types"
 import { ApiHandlerOptions, RouterName, ModelRecord } from "../../shared/api"
 
 import { BaseProvider } from "./base-provider"
-import { getModels } from "./fetchers/modelCache"
+import { getModels, getModelsFromCache } from "./fetchers/modelCache"
 
 import { DEFAULT_HEADERS } from "./constants"
 
@@ -63,9 +63,22 @@ export abstract class RouterProvider extends BaseProvider {
 	override getModel(): { id: string; info: ModelInfo } {
 		const id = this.modelId ?? this.defaultModelId
 
-		return this.models[id]
-			? { id, info: this.models[id] }
-			: { id: this.defaultModelId, info: this.defaultModelInfo }
+		// First check instance models (populated by fetchModel)
+		if (this.models[id]) {
+			return { id, info: this.models[id] }
+		}
+
+		// Fall back to global cache (synchronous disk/memory cache)
+		// This ensures models are available before fetchModel() is called
+		const cachedModels = getModelsFromCache(this.name)
+		if (cachedModels?.[id]) {
+			// Also populate instance models for future calls
+			this.models = cachedModels
+			return { id, info: cachedModels[id] }
+		}
+
+		// Last resort: return default model
+		return { id: this.defaultModelId, info: this.defaultModelInfo }
 	}
 
 	protected supportsTemperature(modelId: string): boolean {

src/core/webview/__tests__/ClineProvider.spec.ts

@@ -237,6 +237,7 @@ vi.mock("../../../integrations/misc/extract-text", () => ({
 vi.mock("../../../api/providers/fetchers/modelCache", () => ({
 	getModels: vi.fn().mockResolvedValue({}),
 	flushModels: vi.fn(),
+	getModelsFromCache: vi.fn().mockReturnValue(undefined),
 }))
 
 vi.mock("../../../shared/modes", () => ({
@@ -308,6 +309,7 @@ vi.mock("../../../integrations/misc/extract-text", () => ({
 vi.mock("../../../api/providers/fetchers/modelCache", () => ({
 	getModels: vi.fn().mockResolvedValue({}),
 	flushModels: vi.fn(),
+	getModelsFromCache: vi.fn().mockReturnValue(undefined),
 }))
 
 vi.mock("../diff/strategies/multi-search-replace", () => ({

src/core/webview/__tests__/ClineProvider.sticky-mode.spec.ts

@@ -151,6 +151,7 @@ vi.mock("../../prompts/system", () => ({
 vi.mock("../../../api/providers/fetchers/modelCache", () => ({
 	getModels: vi.fn().mockResolvedValue({}),
 	flushModels: vi.fn(),
+	getModelsFromCache: vi.fn().mockReturnValue(undefined),
 }))
 
 vi.mock("../../../integrations/misc/extract-text", () => ({