Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: config selection improved logic #54

Merged
merged 14 commits into from
Jun 27, 2023
Merged

Conversation

gosharo
Copy link
Contributor

@gosharo gosharo commented Jun 23, 2023

Signed-off-by: Gosha gosha@rookout.com

Pull Request

Description

Please provide a brief description of the changes made in this pull request.

Related Issue(s)

If this pull request addresses or relates to any open issues, please mention them here using the syntax Fixes #<issue_number> or Resolves #<issue_number>.

Checklist

Before submitting this pull request, please ensure that you have completed the following tasks:

Testing Instructions

Please provide clear instructions on how to test and verify the changes made in this pull request.

Additional Information

Add any additional information or context that would be helpful in understanding and reviewing this pull request.

Signed-off-by: Gosha <gosha@rookout.com>
@gosharo gosharo requested a review from nissim-infra as a code owner June 23, 2023 05:22
gosharo added 3 commits June 23, 2023 08:24
Signed-off-by: Gosha <gosha@rookout.com>
Signed-off-by: Gosha <gosha@rookout.com>
Signed-off-by: Gosha <gosha@rookout.com>
@gosharo
Copy link
Contributor Author

gosharo commented Jun 23, 2023

Github Enforcer opened Task: RK-19031

@sonariorobot sonariorobot changed the title fix: config selection improved logic RK-19031 - fix: config selection improved logic Jun 23, 2023
@gosharo gosharo changed the title RK-19031 - fix: config selection improved logic fix: config selection improved logic Jun 23, 2023
gosharo added 4 commits June 23, 2023 09:02
Signed-off-by: Gosha <gosha@rookout.com>
Signed-off-by: Gosha <gosha@rookout.com>
Signed-off-by: Gosha <gosha@rookout.com>
Signed-off-by: Gosha <gosha@rookout.com>
@gosharo gosharo requested a review from qadiludmer June 23, 2023 06:13
gosharo added 3 commits June 23, 2023 09:17
Signed-off-by: Gosha <gosha@rookout.com>
Signed-off-by: Gosha <gosha@rookout.com>
Signed-off-by: Gosha <gosha@rookout.com>
Signed-off-by: GoshaDozoretz <106976988+gosharo@users.noreply.github.com>
gosharo and others added 2 commits June 27, 2023 12:38
Signed-off-by: GoshaDozoretz <106976988+gosharo@users.noreply.github.com>
Signed-off-by: Gosha <gosha@rookout.com>
@gosharo gosharo merged commit 59f25dc into main Jun 27, 2023
@gosharo gosharo deleted the fix-config-selection-return-value branch June 27, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants