Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: makefile improvence - RK-19036 #59

Merged
merged 18 commits into from
Jun 25, 2023
Merged

fix: makefile improvence - RK-19036 #59

merged 18 commits into from
Jun 25, 2023

Conversation

gosharo
Copy link
Contributor

@gosharo gosharo commented Jun 24, 2023

  • fix: add e2e test
  • fix: add e2e test
  • fix: add e2e test
  • fix: makefile improvence

Pull Request

Description

Please provide a brief description of the changes made in this pull request.

Related Issue(s)

If this pull request addresses or relates to any open issues, please mention them here using the syntax Fixes #<issue_number> or Resolves #<issue_number>.

Checklist

Before submitting this pull request, please ensure that you have completed the following tasks:

Testing Instructions

Please provide clear instructions on how to test and verify the changes made in this pull request.

Additional Information

Add any additional information or context that would be helpful in understanding and reviewing this pull request.

gosharo added 4 commits June 24, 2023 13:46
Signed-off-by: Gosha <gosha@rookout.com>
Signed-off-by: Gosha <gosha@rookout.com>
Signed-off-by: Gosha <gosha@rookout.com>
Signed-off-by: Gosha <gosha@rookout.com>
@gosharo gosharo requested a review from nissim-infra as a code owner June 24, 2023 12:11
@gosharo
Copy link
Contributor Author

gosharo commented Jun 24, 2023

Github Enforcer opened Task: RK-19036

@sonariorobot sonariorobot changed the title fix makefile RK-19036 - fix makefile Jun 24, 2023
@gosharo gosharo changed the title RK-19036 - fix makefile fix: makefile - RK-19036 Jun 24, 2023
@gosharo gosharo requested a review from qadiludmer June 24, 2023 12:15
@gosharo gosharo changed the title fix: makefile - RK-19036 fix: makefile improvence - RK-19036 Jun 24, 2023
makefile Show resolved Hide resolved
@gosharo gosharo requested a review from qadiludmer June 24, 2023 16:47
scripts/init-kind.sh Outdated Show resolved Hide resolved
gosharo added 3 commits June 24, 2023 21:23
Signed-off-by: Gosha <gosha@rookout.com>
Signed-off-by: Gosha <gosha@rookout.com>
Signed-off-by: Gosha <gosha@rookout.com>
@gosharo gosharo requested a review from qadiludmer June 25, 2023 02:36
gosharo added 11 commits June 25, 2023 05:37
Signed-off-by: Gosha <gosha@rookout.com>
Signed-off-by: Gosha <gosha@rookout.com>
Signed-off-by: Gosha <gosha@rookout.com>
Signed-off-by: Gosha <gosha@rookout.com>
Signed-off-by: Gosha <gosha@rookout.com>
Signed-off-by: Gosha <gosha@rookout.com>
Signed-off-by: Gosha <gosha@rookout.com>
Signed-off-by: Gosha <gosha@rookout.com>
Signed-off-by: Gosha <gosha@rookout.com>
Signed-off-by: Gosha <gosha@rookout.com>
Signed-off-by: Gosha <gosha@rookout.com>
@gosharo gosharo merged commit 017d653 into main Jun 25, 2023
@gosharo gosharo deleted the fix-makefile branch June 25, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants