fix: event selection more specific - RK-19082

[gosharo]

Signed-off-by: Gosha gosha@rookout.com

Pull Request

Description

Please provide a brief description of the changes made in this pull request.

Related Issue(s)

If this pull request addresses or relates to any open issues, please mention them here using the syntax Fixes #<issue_number> or Resolves #<issue_number>.

Checklist

Before submitting this pull request, please ensure that you have completed the following tasks:

• Reviewed the Contributing Guidelines for the Piper project.
• Ensured that your changes follow the coding guidelines and style of the project.
• Run the tests locally and made sure they pass.
• Updated the relevant documentation, if applicable.

Testing Instructions

Please provide clear instructions on how to test and verify the changes made in this pull request.

Additional Information

Add any additional information or context that would be helpful in understanding and reviewing this pull request.

[gosharo]

Github Enforcer opened Task: RK-19082

[qadiludmer]

I would use a map instead of this nested switch cases.

the map key will be repo+branch+path

[gosharo]

done !

[qadiludmer]

use map also here

[gosharo]

done

[qadiludmer]

you can flatten the map so you will only have to check single key that is "repo/branch/path"

[gosharo]

done

[qadiludmer]

flatten it

return &map[string]git_provider.CommitFile{
    "repo1/branch1/.workflows/main.yaml": git_provider.CommitFile{
			Path:    utils.SPtr(".workflows/main.yaml"),
			Content: GetContent(".workflows/main.yaml"),
		},
    "repo1/branch1/.workflows/exit.yaml": git_provider.CommitFile{
			Path:    utils.SPtr(".workflows/exit.yaml"),
			Content: GetContent(".workflows/exit.yaml"),
		},
	}

[gosharo]

@qadiludmer not sure that it's better, is much easier to read and add new repos, branches and files in structured map

[qadiludmer]

But the access is less pretty

[gosharo]

Agree, but I have the GetFile and GetFiles function for that

[gosharo]

done

[qadiludmer]

see comments

[qadiludmer]

Give meaningful names to commits to make the review easier :

[qadiludmer]

why do we need a function for retuning a const ? can't we put the map in a global var ?

[gosharo]

hate globals

[gosharo]

also it can be reused in other places too, if needed

[qadiludmer]

Function contains a logic - you don't have any logic here

[gosharo]

yes... after reading a little, moving it to global

[qadiludmer]

var fileContentMap := map[string]*string{
		"main.yaml":       utils.SPtr("main.yaml"),
		"exit.yaml":       utils.SPtr("exit.yaml"),
		"parameters.yaml": utils.SPtr("parameters.yaml"),
	}

[qadiludmer]

and then

var commitFileMap := map[string]*git_provider.CommitFile{
		"repo1/branch1/.workflows/main.yaml": &git_provider.CommitFile{
			Path:    utils.SPtr(".workflows/main.yaml"),
			Content: fileContentMap["main.yaml"],
		},
....
	}

[gosharo]

done

[qadiludmer]

almost. see my second comment

[gosharo]

did it, and renamed it

[qadiludmer]

why do you need this function ? all it does is accessing a map so the caller can do it too

[gosharo]

done

[qadiludmer]

see comment