Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a CardamonRun table to the db #46

Open
ohuu opened this issue Jun 12, 2024 · 4 comments
Open

Add a CardamonRun table to the db #46

ohuu opened this issue Jun 12, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@ohuu
Copy link
Collaborator

ohuu commented Jun 12, 2024

Explicitly storing individual runs will probably help in features going forward and will probably help to simplify some SQL queries.

Proposal

CREATE TABLE IF NOT EXISTS Run (
    id INT NOT NULL AUTOINCREMENT PRIMARY KEY,
    start BIGINT NOT NULL,
    stop BIGINT NOT NULL
);

and then add FOREIGN KEY to run_id's in other tables.

@ohuu
Copy link
Collaborator Author

ohuu commented Jun 12, 2024

We may need to update bits of the code to use this data. E.g. in building datasets and the summary stuff

@ohuu ohuu added the enhancement New feature or request label Jun 12, 2024
@ohuu ohuu self-assigned this Jun 12, 2024
@ohuu
Copy link
Collaborator Author

ohuu commented Jun 13, 2024

actually I'm not sure this makes sense. Cardamon runs are of observations which include multiple scenarios. The only thing that's important is that a scenario was run at a certain time (and possibly in the future, in response to some event - git commit, PR etc). Once a run happens Cardamon doesn't care what other scenarios were run in the same run and it shouldn't help in any queries to know that.

I'm closing this issue until I find a compelling reason to model "runs" in the db.

@ohuu ohuu closed this as completed Jun 13, 2024
@ohuu ohuu reopened this Jun 13, 2024
@ohuu ohuu closed this as not planned Won't fix, can't repro, duplicate, stale Jun 13, 2024
@ohuu
Copy link
Collaborator Author

ohuu commented Jun 28, 2024

We actually need this for the UI, so I'm reopening

@ohuu ohuu reopened this Jun 28, 2024
@anewmandev anewmandev added this to the Cardamon 0.1.0 milestone Aug 19, 2024
@anewmandev
Copy link
Collaborator

@ohuu moving back to triage until you make your bloody mind up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants