Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor cardamon #68

Closed
ohuu opened this issue Aug 21, 2024 · 1 comment
Closed

Refactor cardamon #68

ohuu opened this issue Aug 21, 2024 · 1 comment
Assignees
Labels
question Further information is requested

Comments

@ohuu
Copy link
Collaborator

ohuu commented Aug 21, 2024

Q1. It seems that we need to move functions for fetching UI stuff from the db out of the DAO and into their own classes

At the moment there are a load of functions in the DAOs which seem very specific to the UI. These will never be used by the DAOs so they should probably need to be moved to UI server which means the UI server should have access to the SqlitePool rather than the LocalDAOService

Q2. We probably need to batch saving metrics (both locally and remote) so we don't spam the db or network.

I think metrics are saved one at a time at the moment which we can probably get away with locally but probably not when saving to the remote server

@ohuu ohuu self-assigned this Aug 21, 2024
@ohuu ohuu added the question Further information is requested label Aug 21, 2024
@ohuu
Copy link
Collaborator Author

ohuu commented Aug 28, 2024

This is basically done I just need to merge all this back into main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant