Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #191259 #1

Open
Ros-Cos opened this issue Jan 23, 2024 · 0 comments
Open

Fixes #191259 #1

Ros-Cos opened this issue Jan 23, 2024 · 0 comments
Assignees
@Ros-Cos
Labels
bug Something isn't working documentation Improvements or additions to documentation duplicate This issue or pull request already exists enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed invalid This doesn't seem right question Further information is requested wontfix This will not be worked on

Comments

@Ros-Cos
Copy link
Owner

Ros-Cos commented Jan 23, 2024

Fixes #191259

This implements a rough version of the preview on active picker selection.

2024-01-12.10-11-40.mp4

This has:

  • Previewing on active selection
  • Restoring state on escape

TODO:

  • Try to get a 'true preview' editor state where we open a preview editor regardless of user settings.
  • Omit editor navigation from back/forward history.

cc: @TylerLeonhardt @bpasero

Originally posted by @andreamah in microsoft/vscode#202306
@Ros-Cos Ros-Cos added bug Something isn't working documentation Improvements or additions to documentation duplicate This issue or pull request already exists labels Jan 23, 2024
@Ros-Cos Ros-Cos assigned Ros-Cos and unassigned Ros-Cos Jan 23, 2024
@Ros-Cos Ros-Cos added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers invalid This doesn't seem right question Further information is requested wontfix This will not be worked on bug Something isn't working and removed bug Something isn't working labels Jan 23, 2024
@Ros-Cos Ros-Cos self-assigned this Jan 23, 2024
@Ros-Cos Ros-Cos mentioned this issue Jan 28, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ros-Cos Ros-Cos

Labels
bug Something isn't working documentation Improvements or additions to documentation duplicate This issue or pull request already exists enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed invalid This doesn't seem right question Further information is requested wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Ros-Cos