Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No logic for structure diffusion #12

Open
jsrimr opened this issue Sep 21, 2023 · 4 comments
Open

No logic for structure diffusion #12

jsrimr opened this issue Sep 21, 2023 · 4 comments

Comments

@jsrimr
Copy link

jsrimr commented Sep 21, 2023

Following inference.py code, I come to doubt if there exist code for structure diffusion.

Is this intended or I'm just missing something?

Any advice would help a lot!

@0merle0
Copy link
Member

0merle0 commented Sep 25, 2023

There is no diffusion in str space happening here, only in sequence space

@jsrimr
Copy link
Author

jsrimr commented Sep 26, 2023

Sad to hear that. Do you have any plan to integrate structure space diffusion as described in the paper?

@0merle0
Copy link
Member

0merle0 commented Sep 26, 2023

Maybe there's a misunderstanding here? Where do you see diffusion in structure space in the text?

@jsrimr
Copy link
Author

jsrimr commented Sep 27, 2023

As the title of the paper is 'Joint Generation of Protein Sequence and Structure', I thought it's d be natural to diffuse both sequence and structure. Maybe I'm getting something wrong.. Should the structure be fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants