Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send headers with context menu download #5

Open
Mayzie opened this issue Nov 17, 2017 · 3 comments
Open

Send headers with context menu download #5

Mayzie opened this issue Nov 17, 2017 · 3 comments

Comments

@Mayzie
Copy link

Mayzie commented Nov 17, 2017

When right-clicking a link and selecting "Download with Aria2", it should launch the download with the same HTTP headers as the session the context menu is activated from.

This is needed to support downloads utilising HTTP authorisation fields.

@RossWang
Copy link
Owner

RossWang commented Nov 17, 2017

This Add-on interrupts and records the web request that Firefox sends, so it cannot get the headers from context menu which Firefox doesn't send the request.

But if I have time, I will use another way to implement this.

@Mayzie
Copy link
Author

Mayzie commented Nov 18, 2017

Hi Ross,

Thanks for your latest commit!

However, it doesn't handle the Authorization header.

Cheers.

@RossWang
Copy link
Owner

I am sorry for that. I guessed you were talking about the "cookie" field, but it was not.

In the latest commit, I added the 'Authorization' header support for the auto observer, but it cannot handle the 'Authorization' header for the download request from the context menu because of the reason I talk before.

I have not figured out the good method to handle the 'Authorization' header for the download request from the context menu. If you have any good idea, please tell me.

@RossWang RossWang reopened this Nov 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants