Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate exit in Kernel::Output::HTML::Layout #180

Closed
bschmalhofer opened this issue Jul 10, 2020 · 2 comments
Closed

Eliminate exit in Kernel::Output::HTML::Layout #180

bschmalhofer opened this issue Jul 10, 2020 · 2 comments
Assignees
@bschmalhofer
Labels
enhancement New feature or request
Milestone
OTOBO 10.1.1

Comments

@bschmalhofer
Copy link
Contributor

bschmalhofer commented Jul 10, 2020 •
edited
Loading

The subs FatalError() and CustomerFatalError() call exit after printing HTML with the error message. The reason is not obvious. Under Apache/mod_perl this still return an status code of 200 (OK). Under Gazelle the HTTP status code 500 (Internal Server Error) is returned.
@bschmalhofer bschmalhofer added the invalid The report was either incorrect, or it describes the correct behavior. label Jul 10, 2020
@bschmalhofer bschmalhofer added this to the OTOBO 10.1 milestone Jul 10, 2020
@bschmalhofer bschmalhofer added enhancement New feature or request and removed invalid The report was either incorrect, or it describes the correct behavior. labels Jul 14, 2020
@bschmalhofer bschmalhofer modified the milestones: OTOBO 10.1, OTOBO 11.0 Aug 7, 2020
@bschmalhofer
Copy link
Contributor Author

bschmalhofer commented Aug 7, 2020 •
edited
Loading

The preferred solution is to implement #320 .
See also #323 for how this is handled under PSGI.

@bschmalhofer bschmalhofer mentioned this issue Aug 14, 2020
Closed
@bschmalhofer
Copy link
Contributor Author

There is no need to worry about the calls to exit when there is a chance that support for non-PSGI will be removed. Closing the issue.

@bschmalhofer bschmalhofer modified the milestones: OTOBO 11.0, OTOBO 10.1 Jan 22, 2021
@bschmalhofer bschmalhofer self-assigned this Nov 28, 2021
@bschmalhofer bschmalhofer modified the milestones: OTOBO 10.1, OTOBO 10.1.1 Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bschmalhofer bschmalhofer

Labels
enhancement New feature or request
Projects
None yet
Milestone
OTOBO 10.1.1
Development

No branches or pull requests
1 participant
@bschmalhofer