Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DatePickerE: Add focus trap #2870

Closed
jpveooys opened this issue Dec 6, 2021 · 2 comments · Fixed by #2980
Closed

DatePickerE: Add focus trap #2870

jpveooys opened this issue Dec 6, 2021 · 2 comments · Fixed by #2980
Assignees
Labels
Package: react-component-library Package/code type Size: Small Assessed as small task Type: Enhancement New feature or request

Comments

@jpveooys
Copy link
Collaborator

jpveooys commented Dec 6, 2021

From @k9dh3zij (in #2841):

Can we make it so that the Sheet contains its own tab sequence. (Tab and Shift + Tab do not move focus outside the dialog)

This is based on https://www.w3.org/TR/wai-aria-practices/examples/dialog-modal/datepicker-dialog.html

There is a library that can do this: https://github.com/focus-trap/focus-trap-react

However, from testing, there seems to be a bug in the underlying library (https://github.com/focus-trap/focus-trap) – when a date after the first of the month is focused, the tab key stops functioning (while Shift+Tab continues to work).

This needs further investigation and a bug to be reported.

@jpveooys jpveooys added Status: Blocked Unable to progress currently due to internal/external blocker Type: Enhancement New feature or request Package: react-component-library Package/code type Size: Small Assessed as small task labels Dec 6, 2021
@jpveooys
Copy link
Collaborator Author

jpveooys commented Dec 6, 2021

I've opened an issue regarding the problem encountered with focus-trap here: focus-trap/focus-trap#565

@jpveooys
Copy link
Collaborator Author

@jpveooys jpveooys removed the Status: Blocked Unable to progress currently due to internal/external blocker label Jan 13, 2022
@jpveooys jpveooys self-assigned this Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: react-component-library Package/code type Size: Small Assessed as small task Type: Enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant