Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DatePickerE: Tabbing away from day in calendar should clear range highlight #2872

Open
jpveooys opened this issue Dec 6, 2021 · 7 comments
Open

DatePickerE: Tabbing away from day in calendar should clear range highlight #2872

jpveooys opened this issue Dec 6, 2021 · 7 comments
Assignees
@m7kvqbe1
Labels
Package: react-component-library Package/code type Size: Small Assessed as small task Status: Stale Issue with no activity for the past 60 days Type: Bug Inconsistencies or issues which have caused a problem for users or implementors

Comments

@jpveooys
Copy link
Contributor

jpveooys commented Dec 6, 2021

When the date picker is in range mode and a second date is being selected (focused) using the keyboard arrow keys, the days between the first and focused date are shaded.

However, the shading isn't cleared when tabbing to a different element. This is due to react-day-picker v7 not exposing a onDayBlur prop (which would allow us to clear the highlight).

However, the prop has been added for react-day-picker v8 which is currently in beta, so this should be fixable once a stable version of it is released.
@jpveooys jpveooys added Status: Blocked Unable to progress currently due to internal/external blocker Type: Bug Inconsistencies or issues which have caused a problem for users or implementors Package: react-component-library Package/code type Size: Small Assessed as small task labels Dec 6, 2021
@jpveooys jpveooys mentioned this issue Dec 6, 2021
Merged
8 tasks
@jpveooys
Copy link
Contributor Author

jpveooys commented Dec 6, 2021 •
edited
Loading

Note: v8 is due for release before the end of the year: https://github.com/gpbl/react-day-picker/discussions/1316

We could start using it for DatePickerE only using an alias.

@jpveooys jpveooys changed the title DatePickerE: Tabbing away from date should clear range highlight DatePickerE: Tabbing away from day in calendar should clear range highlight Dec 7, 2021
@gpbl
Copy link

gpbl commented Dec 15, 2021

👋 hey thanks for looking at react-day-picker!

Please remember v8 is a major update mainly incompatible with the previous version. If you are evaluating the beta or considering to upgrade, consider to contact the mantainers at the DayPicker Slack. We can help for real use-cases for DayPicker and see how it is implemented around.

@jpveooys
Copy link
Contributor Author

Hi @gpbl 👋

Thanks for visiting! 😄

Our date picker component (DatePicker) is built on react-day-picker and we're currently working on a new version of it (DatePickerE) as you've probably gathered 🙂

We're planning on having a look at migrating DatePickerE to the react-day-picker v8 beta as there's lots of good stuff in there we've been looking for 😄 But realistically, I think this will be in January now (with Christmas time off etc.)

Thanks again!

@jpveooys jpveooys removed the Status: Blocked Unable to progress currently due to internal/external blocker label Dec 20, 2021
@jpveooys jpveooys self-assigned this Dec 20, 2021
@jpveooys
Copy link
Contributor Author

Working branch: https://github.com/defencedigital/mod-uk-design-system/tree/feature/date-picker-e-v8

@jpveooys jpveooys added the Status: Blocked Unable to progress currently due to internal/external blocker label Jan 4, 2022
@jpveooys jpveooys removed the Status: Blocked Unable to progress currently due to internal/external blocker label Jan 17, 2022
@jpveooys jpveooys mentioned this issue Jan 18, 2022
Draft
3 tasks
@jpveooys jpveooys added the Status: Blocked Unable to progress currently due to internal/external blocker label Jan 18, 2022
@github-actions
Copy link

This issue has been marked as stale because it has been open for 60 days with no activity

@github-actions github-actions bot added the Status: Stale Issue with no activity for the past 60 days label Mar 21, 2022
@markhigham markhigham removed the Status: Stale Issue with no activity for the past 60 days label Apr 5, 2024
@markhigham markhigham removed the Status: Blocked Unable to progress currently due to internal/external blocker label Apr 5, 2024
@github-actions GitHub Actions
Copy link

This issue has been marked as stale because it has been open for 60 days with no activity

@github-actions github-actions bot added the Status: Stale Issue with no activity for the past 60 days label Jun 10, 2024
@m7kvqbe1 m7kvqbe1 assigned m7kvqbe1 and unassigned jpveooys Jun 19, 2024
@m7kvqbe1 m7kvqbe1 removed the Status: Stale Issue with no activity for the past 60 days label Jun 19, 2024
@github-actions GitHub Actions
Copy link

This issue has been marked as stale because it has been open for 60 days with no activity

@github-actions github-actions bot added the Status: Stale Issue with no activity for the past 60 days label Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@m7kvqbe1 m7kvqbe1

Labels
Package: react-component-library Package/code type Size: Small Assessed as small task Status: Stale Issue with no activity for the past 60 days Type: Bug Inconsistencies or issues which have caused a problem for users or implementors
Projects
Tactical Board
Status: Ready
Milestone
No milestone
Development

No branches or pull requests
4 participants
@gpbl @markhigham @m7kvqbe1 @jpveooys