Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove generate-exports.sh from icon-library #744

Closed
thyhjwb6 opened this issue Mar 18, 2020 · 1 comment
Closed

Remove generate-exports.sh from icon-library #744

thyhjwb6 opened this issue Mar 18, 2020 · 1 comment
Labels
Package: icon-library Package/code type Type: Techdebt Requires or will require rework

Comments

@thyhjwb6
Copy link
Collaborator

As part of #723 rm src/icons/index.tsx was added to remove the file which was causing issues. With the recent upgrade of svgr, it is now attempting to output index.ts. If we can use this file rather than our own custom generate-exports.sh it would be better as it is now confusing how this works.
@thyhjwb6 thyhjwb6 added Type: Techdebt Requires or will require rework Package: icon-library Package/code type labels Mar 18, 2020
@el7h1rw2 el7h1rw2 added this to the Technical debt is paid down milestone Apr 14, 2020
@el7h1rw2 el7h1rw2 mentioned this issue Apr 14, 2020
Closed
13 tasks
@m7kvqbe1 m7kvqbe1 self-assigned this Apr 17, 2020
@m7kvqbe1 m7kvqbe1 added the Status: Blocked Unable to progress currently due to internal/external blocker label Apr 20, 2020
@m7kvqbe1
Copy link
Collaborator

I've looked into this and I can't seem to get past the race condition issue with the @svgr/cli tool.

I've raised an issue here (gregberge/svgr#433) and provided them with a repro branch in this repo.

@m7kvqbe1 m7kvqbe1 removed the Status: Blocked Unable to progress currently due to internal/external blocker label Apr 29, 2020
@m7kvqbe1 m7kvqbe1 removed their assignment May 1, 2020
@el7h1rw2 el7h1rw2 closed this as completed May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Package: icon-library Package/code type Type: Techdebt Requires or will require rework
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@m7kvqbe1 @thyhjwb6 @el7h1rw2