Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPFS-Companion is creating non-working URLs for this repo #28

Open
rpodgorny opened this issue Jul 8, 2020 · 6 comments
Open

IPFS-Companion is creating non-working URLs for this repo #28

rpodgorny opened this issue Jul 8, 2020 · 6 comments
Labels
bug Something isn't working upstream-bug

Comments

@rpodgorny
Copy link

what i just experienced:

  1. browsed the files of your ipfs arch repo at http://x86-64.archlinux.pkg.pacman.store.ipns.localhost:8080/iso/latest (local gateway with local ipfs node)
  2. clicked "copy shareable link" at the ipfs companion firefox extension
  3. pasted the url to address bar in another tab: https://x86-64.archlinux.pkg.pacman.store.ipns.dweb.link/iso/latest
  4. i ended up with ssl certificate error:
Websites prove their identity via certificates. Firefox does not trust this site because it uses a certificate that is not valid for x86-64.archlinux.pkg.pacman.store.ipns.dweb.link. The certificate is only valid for the following names: *.i.ipfs.io, *.ipfs.dweb.link, *.ipfs.io, *.ipns.dweb.link, dweb.link, ipfs.io
 
Error code: SSL_ERROR_BAD_CERT_DOMAIN

...so i guess the "*" wildcard character only covers a single-level subdomain, not "infinite"-level.

migrating to something like "x86-64-archlinux-pkg-pacman-store.ipns.dweb.link" would probably solve the issue but i can imagine it's not feasible for some reason i'm not aware of. :-(

...so, what to do now?

@teknomunk
Copy link

I believe this issue is not specific to this project, but an issue with IPFS, the dweb.link webserver and/or the IPFS companion, and maybe with subdomain-certificate handling in the web browser you use.

As you note, the subdomain is causing a certificate error. I tried navigating to https://dweb.link/ipns/x86_64.archlinux.pkg.pqcman.store/iso/latest/, and was promptly redirected to the subdomain that you report as not working. This redirect is being done by the webserver sitting at dweb.link (and is either the ipfs daemon itself or the daemon with a reverse proxy in front of it).

The subdomain redirect was recently added to IPFS. The companion is likely taking this into account (I don't have the companion installed, so I can't check it myself).

My suggestion is to make a bug report at the IPFS project, as this is probably the result of the subdomain redirect and is there responsibility to fix. This issue looks like our affects more sites than just pacman.store.

If you do, please add a link to the issue here so that we can track it.

@mohe2015
Copy link

mohe2015 commented Jul 9, 2020

Web browsers don't support multi level wildcard certificates so this should probably be changed.

@RubenKelevra
Copy link
Owner

RubenKelevra commented Jul 10, 2020

@rpodgorny

I'm open to suggestions and I can confirm this issue, but I don't think a non-dotted domain name would change anything.

Please report this issue upstream, as I don't think I can do anything to fix this. Additionally my bug about the non-working redirect is still open and escalated to go-ipfs, see - this might be related.

ipfs/ipfs-companion#877
ipfs/kubo#7439

@mohe2015 wrote:

Web browsers don't support multi level wildcard certificates so this should probably be changed.

Right, so https://store.ipns.dweb.link works fine. But I currently have not enough money on my bank account to get TLD. :)

@mohe2015
Copy link

@RubenKelevra I'm sorry, I didn't read properly.

@RubenKelevra RubenKelevra added bug Something isn't working submit-upstream This need to be reported upstream. labels Jul 11, 2020
@rpodgorny
Copy link
Author

agreed, this is more fundamental problem of ipfs (and/or ipfs-companion) itself.

i've subscribed to the mentioned bug reports and will follow the progress there. feel free to close this one. thanks.

@RubenKelevra
Copy link
Owner

@rpodgorny Your welcome!

Will close this one as soon as the issue is fixed upstream.

@RubenKelevra RubenKelevra added upstream-bug and removed submit-upstream This need to be reported upstream. wait for feedback labels Jul 20, 2020
@RubenKelevra RubenKelevra changed the title migrate to non-dotted dns name? IPFS-Companion is creating non-working URLs for this repo Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working upstream-bug
Projects
None yet
Development

No branches or pull requests

4 participants