Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility with Reach Entity Attributes #13

Closed
Neubulae opened this issue Mar 10, 2021 · 16 comments
Closed

Incompatibility with Reach Entity Attributes #13

Neubulae opened this issue Mar 10, 2021 · 16 comments
Labels
incompatibilty Incompatible with another mod

Comments

@Neubulae
Copy link

three individual crash reports all in one go:
crash-2021-03-11_03.00.19-server.txt
crash-2021-03-11_03.00.23-server.txt
crash-2021-03-11_03.00.24-client.txt

@RubixDev
Copy link
Owner

Seems to be an incompatibilty with reach-entity-attributes. Did it work without crashing since your last crash report once? I haven't touched reachDistance since then.
I hope it'll be enough if I just lower the priority of my mixin, as it's pretty much redundant with that mod installed.

@RubixDev RubixDev added the incompatibilty Incompatible with another mod label Mar 10, 2021
@RubixDev
Copy link
Owner

RubixDev commented Mar 10, 2021

Also have you already tried updating reach-entity-attributes? I saw you use v1.0.2 but at least v2.0.0 is out already

@RubixDev
Copy link
Owner

RubixDev commented Mar 10, 2021

Can you try if this works?

@RubixDev RubixDev added the not enough information Further information is requested label Mar 10, 2021
@Neubulae
Copy link
Author

Seems to be an incompatibilty with reach-entity-attributes. Did it work without crashing since your last crash report once? I haven't touched reachDistance since then.
I hope it'll be enough if I just lower the priority of my mixin, as it's pretty much redundant with that mod installed.

no, last report immediately followed by this

@RubixDev
Copy link
Owner

Can you try if this works?

Have you tried that? I can't really test it myself atm

@Neubulae
Copy link
Author

@RubixDev
Copy link
Owner

Next try: This should in theory work, at least it did in my tests with reach-entity-attributes v1.0.1, I would just like a confirmation before I close the issue.
I now fully disable the conflicting mixins of my mod while reach-entity-attributes is installed.

@Neubulae
Copy link
Author

confirmed working(at least the client booted up). One thing notable is that REA 2.0 is only available for 1.17. thnakx a lot

@RubixDev RubixDev changed the title what Incompatibility with Reach Entity Attributes Mar 12, 2021
@RubixDev RubixDev removed the not enough information Further information is requested label Mar 12, 2021
@Mattabase
Copy link

Still an issue in 1.19

@Mattabase
Copy link

Happy to grab a log if need be, you can reproduce it by installing origins which uses REA causing a conflict with RUG

@RubixDev RubixDev reopened this Jun 30, 2022
@RubixDev
Copy link
Owner

I think, I already know the cause, but since I am on vacation now I will have to find a better wifi connection somewhere before I can work on it

@RubixDev
Copy link
Owner

RubixDev commented Jul 1, 2022

@Mattabase can you please try this pre-release? When it works I can make it stable

@Mattabase
Copy link

Mattabase commented Jul 1, 2022

Quick test and looks to have stopped the crash but the reach rule in Rug seems to not be applying

Doing more testing with a smaller instance, this was being done in my large test instance.

@Mattabase
Copy link

image
Same issue in a smaller pack, no more crash however reach rule does not apply

@RubixDev
Copy link
Owner

RubixDev commented Jul 1, 2022

That is to be expected. When you have a look at the README it says reachDistance is disabled when REA is installed, because they both try to change the same vanilla constants. It should be possible to use another mod based on REA to instead change the player's range though (like Reach Out maybe).

@Mattabase
Copy link

Cool thanks for the crash fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
incompatibilty Incompatible with another mod
Projects
None yet
Development

No branches or pull requests

3 participants