Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Line level comments #4

Open
ankurlucknowi opened this issue Jul 5, 2024 · 0 comments
Open

Introduce Line level comments #4

ankurlucknowi opened this issue Jul 5, 2024 · 0 comments

Comments

@ankurlucknowi
Copy link
Contributor

The current script posts the entire review as a conversation comment on the PR. This creates difficulty in

  1. understanding the comment in conjunction with code.
  2. This does not count as an open code review on that PR, so closing these comments is not mandatory.

We need to change the script to start a code review on the PR and comments at those specific lines of the code.
The current code has references to the filenumber and line number of the comments. We need to fire the right GitHub API to post these comments at a line level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant