Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit packages disabled in CI and enable all the ones we can #172

Open
LegNeato opened this issue Mar 19, 2025 · 4 comments
Open

Audit packages disabled in CI and enable all the ones we can #172

LegNeato opened this issue Mar 19, 2025 · 4 comments

Comments

@LegNeato
Copy link
Contributor

LegNeato commented Mar 19, 2025

CI excludes packages here from building:

run: cargo build --workspace --exclude "optix" --exclude "path_tracer" --exclude "denoiser" --exclude "add" --exclude "ex*"

Without having these tested in CI, we will not be aware if they regress / stop building.

We should figure out why these are disabled and possibly create custom jobs for them if required.

@LegNeato
Copy link
Contributor Author

The excludes were added in #1

@jorge-ortega
Copy link
Collaborator

With #188, I think we should be able to build add and even test it when we land #184.
The rest have to do with Optix, which we still don't have a solution for in our CI yet. I'm looking back to our discussion in #142. We'll need one if we want to remain its stewards.

@adamcavendish
Copy link
Contributor

The OptiX ones I think the major issue is OptiX SDK installation which users will have to accept a licence and there is no public download URL without login.

@jorge-ortega
Copy link
Collaborator

Seems then the best anyone ever could do is build and test locally. Then these would just stay disable indefinitely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants