Skip to content

Commit 142639a

Browse files
fltorobclark
authored andcommitted
drm/msm/a6xx: fix crashstate capture for A650
A650 has a separate RSCC region, so dump RSCC registers separately, reading them from the RSCC base. Without this change a GPU hang will cause a system reset if CONFIG_DEV_COREDUMP is enabled. Signed-off-by: Jonathan Marek <jonathan@marek.ca> Reviewed-by: Jordan Crouse <jcrouse@codeaurora.org> Signed-off-by: Rob Clark <robdclark@chromium.org>
1 parent 62a35e8 commit 142639a

File tree

3 files changed

+31
-11
lines changed

3 files changed

+31
-11
lines changed

Diff for: drivers/gpu/drm/msm/adreno/a6xx_gmu.h

+5
Original file line numberDiff line numberDiff line change
@@ -127,6 +127,11 @@ static inline u64 gmu_read64(struct a6xx_gmu *gmu, u32 lo, u32 hi)
127127
readl_poll_timeout((gmu)->mmio + ((addr) << 2), val, cond, \
128128
interval, timeout)
129129

130+
static inline u32 gmu_read_rscc(struct a6xx_gmu *gmu, u32 offset)
131+
{
132+
return msm_readl(gmu->rscc + (offset << 2));
133+
}
134+
130135
static inline void gmu_write_rscc(struct a6xx_gmu *gmu, u32 offset, u32 value)
131136
{
132137
return msm_writel(value, gmu->rscc + (offset << 2));

Diff for: drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c

+18-7
Original file line numberDiff line numberDiff line change
@@ -736,7 +736,8 @@ static void a6xx_get_ahb_gpu_registers(struct msm_gpu *gpu,
736736
static void _a6xx_get_gmu_registers(struct msm_gpu *gpu,
737737
struct a6xx_gpu_state *a6xx_state,
738738
const struct a6xx_registers *regs,
739-
struct a6xx_gpu_state_obj *obj)
739+
struct a6xx_gpu_state_obj *obj,
740+
bool rscc)
740741
{
741742
struct adreno_gpu *adreno_gpu = to_adreno_gpu(gpu);
742743
struct a6xx_gpu *a6xx_gpu = to_a6xx_gpu(adreno_gpu);
@@ -755,9 +756,17 @@ static void _a6xx_get_gmu_registers(struct msm_gpu *gpu,
755756
u32 count = RANGE(regs->registers, i);
756757
int j;
757758

758-
for (j = 0; j < count; j++)
759-
obj->data[index++] = gmu_read(gmu,
760-
regs->registers[i] + j);
759+
for (j = 0; j < count; j++) {
760+
u32 offset = regs->registers[i] + j;
761+
u32 val;
762+
763+
if (rscc)
764+
val = gmu_read_rscc(gmu, offset);
765+
else
766+
val = gmu_read(gmu, offset);
767+
768+
obj->data[index++] = val;
769+
}
761770
}
762771
}
763772

@@ -777,16 +786,18 @@ static void a6xx_get_gmu_registers(struct msm_gpu *gpu,
777786

778787
/* Get the CX GMU registers from AHB */
779788
_a6xx_get_gmu_registers(gpu, a6xx_state, &a6xx_gmu_reglist[0],
780-
&a6xx_state->gmu_registers[0]);
789+
&a6xx_state->gmu_registers[0], false);
790+
_a6xx_get_gmu_registers(gpu, a6xx_state, &a6xx_gmu_reglist[1],
791+
&a6xx_state->gmu_registers[1], true);
781792

782793
if (!a6xx_gmu_gx_is_on(&a6xx_gpu->gmu))
783794
return;
784795

785796
/* Set the fence to ALLOW mode so we can access the registers */
786797
gpu_write(gpu, REG_A6XX_GMU_AO_AHB_FENCE_CTRL, 0);
787798

788-
_a6xx_get_gmu_registers(gpu, a6xx_state, &a6xx_gmu_reglist[1],
789-
&a6xx_state->gmu_registers[1]);
799+
_a6xx_get_gmu_registers(gpu, a6xx_state, &a6xx_gmu_reglist[2],
800+
&a6xx_state->gmu_registers[2], false);
790801
}
791802

792803
#define A6XX_GBIF_REGLIST_SIZE 1

Diff for: drivers/gpu/drm/msm/adreno/a6xx_gpu_state.h

+8-4
Original file line numberDiff line numberDiff line change
@@ -341,10 +341,6 @@ static const u32 a6xx_gmu_cx_registers[] = {
341341
0x5157, 0x5158, 0x515d, 0x515d, 0x5162, 0x5162, 0x5164, 0x5165,
342342
0x5180, 0x5186, 0x5190, 0x519e, 0x51c0, 0x51c0, 0x51c5, 0x51cc,
343343
0x51e0, 0x51e2, 0x51f0, 0x51f0, 0x5200, 0x5201,
344-
/* GPU RSCC */
345-
0x8c8c, 0x8c8c, 0x8d01, 0x8d02, 0x8f40, 0x8f42, 0x8f44, 0x8f47,
346-
0x8f4c, 0x8f87, 0x8fec, 0x8fef, 0x8ff4, 0x902f, 0x9094, 0x9097,
347-
0x909c, 0x90d7, 0x913c, 0x913f, 0x9144, 0x917f,
348344
/* GMU AO */
349345
0x9300, 0x9316, 0x9400, 0x9400,
350346
/* GPU CC */
@@ -357,8 +353,16 @@ static const u32 a6xx_gmu_cx_registers[] = {
357353
0xbc00, 0xbc16, 0xbc20, 0xbc27,
358354
};
359355

356+
static const u32 a6xx_gmu_cx_rscc_registers[] = {
357+
/* GPU RSCC */
358+
0x008c, 0x008c, 0x0101, 0x0102, 0x0340, 0x0342, 0x0344, 0x0347,
359+
0x034c, 0x0387, 0x03ec, 0x03ef, 0x03f4, 0x042f, 0x0494, 0x0497,
360+
0x049c, 0x04d7, 0x053c, 0x053f, 0x0544, 0x057f,
361+
};
362+
360363
static const struct a6xx_registers a6xx_gmu_reglist[] = {
361364
REGS(a6xx_gmu_cx_registers, 0, 0),
365+
REGS(a6xx_gmu_cx_rscc_registers, 0, 0),
362366
REGS(a6xx_gmu_gx_registers, 0, 0),
363367
};
364368

0 commit comments

Comments
 (0)