Skip to content

Commit 1ddee69

Browse files
andy-shevlinusw
authored andcommitted
pinctrl: cy8c95x0: Respect IRQ trigger settings from firmware
Some of the platforms may connect the INT pin via inversion logic effectively make the triggering to be active-low. Remove explicit trigger flag to respect the settings from firmware. Without this change even idling chip produces spurious interrupts and kernel disables the line in the result: irq 33: nobody cared (try booting with the "irqpoll" option) CPU: 0 UID: 0 PID: 125 Comm: irq/33-i2c-INT3 Not tainted 6.12.0-00236-g8b874ed11dae #64 Hardware name: Intel Corp. QUARK/Galileo, BIOS 0x01000900 01/01/2014 ... handlers: [<86e86bea>] irq_default_primary_handler threaded [<d153e44a>] cy8c95x0_irq_handler [pinctrl_cy8c95x0] Disabling IRQ #33 Fixes: e6cbbe4 ("pinctrl: Add Cypress cy8c95x0 support") Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Link: https://lore.kernel.org/20250117142304.596106-2-andriy.shevchenko@linux.intel.com Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
1 parent 0a7404f commit 1ddee69

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/pinctrl/pinctrl-cy8c95x0.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -1355,7 +1355,7 @@ static int cy8c95x0_irq_setup(struct cy8c95x0_pinctrl *chip, int irq)
13551355

13561356
ret = devm_request_threaded_irq(chip->dev, irq,
13571357
NULL, cy8c95x0_irq_handler,
1358-
IRQF_ONESHOT | IRQF_SHARED | IRQF_TRIGGER_HIGH,
1358+
IRQF_ONESHOT | IRQF_SHARED,
13591359
dev_name(chip->dev), chip);
13601360
if (ret) {
13611361
dev_err(chip->dev, "failed to request irq %d\n", irq);

0 commit comments

Comments
 (0)