Skip to content

Commit 53870c6

Browse files
BennoLossinojeda
authored andcommitted
rust: pin-init: fix broken rust doc link
Rust 1.92.0 warns when building the documentation that [`PinnedDrop`] is an invalid reference. This is correct and it's weird that it didn't warn before, so fix the link. [ The reason is that it is hidden -- I had asked about that in the upstream PR that changed the behavior because I wasn't sure it was intentional (and thus whether we needed to fix this and other cases): rust-lang/rust#147153 (comment) It turns out it was not, and it has been fixed for 1.92.0's upcoming release thanks to Guillaume and León. So we do not strictly need this patch and the other changes anymore: rust-lang/rust#147809 However, checking hidden/private items or, even better, a runtime toggle to be able to see those on the fly, is something that I think would be quite nice so I have had it in our usual lists for a while. Guillaume is open to the idea and perhaps experimenting with an implementation on our side first -- he asked me to open issues upstream: rust-lang/rust#149105 rust-lang/rust#149106 - Miguel ] Signed-off-by: Benno Lossin <lossin@kernel.org> Link: https://patch.msgid.link/20251016211740.653599-1-lossin@kernel.org Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
1 parent 1aaa5cf commit 53870c6

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

rust/pin-init/src/macros.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -506,6 +506,8 @@ pub use ::paste::paste;
506506
/// Creates a `unsafe impl<...> PinnedDrop for $type` block.
507507
///
508508
/// See [`PinnedDrop`] for more information.
509+
///
510+
/// [`PinnedDrop`]: crate::PinnedDrop
509511
#[doc(hidden)]
510512
#[macro_export]
511513
macro_rules! __pinned_drop {

0 commit comments

Comments
 (0)