Skip to content

Commit 9ad665e

Browse files
Dev Jainakpm00
Dev Jain
authored andcommittedMay 24, 2024
selftests/mm: compaction_test: fix incorrect write of zero to nr_hugepages
Currently, the test tries to set nr_hugepages to zero, but that is not actually done because the file offset is not reset after read(). Fix that using lseek(). Link: https://lkml.kernel.org/r/20240521074358.675031-3-dev.jain@arm.com Fixes: bd67d5c ("Test compaction of mlocked memory") Signed-off-by: Dev Jain <dev.jain@arm.com> Cc: <stable@vger.kernel.org> Cc: Anshuman Khandual <anshuman.khandual@arm.com> Cc: Shuah Khan <shuah@kernel.org> Cc: Sri Jayaramappa <sjayaram@akamai.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
1 parent d4202e6 commit 9ad665e

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed
 

‎tools/testing/selftests/mm/compaction_test.c

+2
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,8 @@ int check_compaction(unsigned long mem_free, unsigned long hugepage_size)
108108
goto close_fd;
109109
}
110110

111+
lseek(fd, 0, SEEK_SET);
112+
111113
/* Start with the initial condition of 0 huge pages*/
112114
if (write(fd, "0", sizeof(char)) != sizeof(char)) {
113115
ksft_print_msg("Failed to write 0 to /proc/sys/vm/nr_hugepages: %s\n",

0 commit comments

Comments
 (0)
Please sign in to comment.