Bluetooth: iso: Always release hdev at the end of iso_listen_bis

iulia-tanasescu · Vudentz · commit 9c76fff747a7 · 2024-12-12T09:24:05.000-05:00
Since hci_get_route holds the device before returning, the hdev should be released with hci_dev_put at the end of iso_listen_bis even if the function returns with an error. Fixes: 02171da ("Bluetooth: ISO: Add hcon for listening bis sk") Signed-off-by: Iulia Tanasescu <iulia.tanasescu@nxp.com> Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
diff --git a/net/bluetooth/iso.c b/net/bluetooth/iso.c
@@ -1158,10 +1158,9 @@ static int iso_listen_bis(struct sock *sk)
 		goto unlock;
 	}
 
-	hci_dev_put(hdev);
-
 unlock:
 	hci_dev_unlock(hdev);
+	hci_dev_put(hdev);
 	return err;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -1158,10 +1158,9 @@ static int iso_listen_bis(struct sock *sk)`
`1158`	`1158`	`goto unlock;`
`1159`	`1159`	`}`
`1160`	`1160`
`1161`		`- hci_dev_put(hdev);`
`1162`		`-`
`1163`	`1161`	`unlock:`
`1164`	`1162`	`hci_dev_unlock(hdev);`
	`1163`	`+ hci_dev_put(hdev);`
`1165`	`1164`	`return err;`
`1166`	`1165`	`}`
`1167`	`1166`