Skip to content

Commit e0910c8

Browse files
committed
dm raid: fix discard limits for raid1 and raid10
Block core warned that discard_granularity was 0 for dm-raid with personality of raid1. Reason is that raid_io_hints() was incorrectly special-casing raid1 rather than raid0. But since commit 29efc39 ("md/md0: optimize raid0 discard handling") even raid0 properly handles large discards. Fix raid_io_hints() by removing discard limits settings for raid1. Also, fix limits for raid10 by properly stacking underlying limits as done in blk_stack_limits(). Depends-on: 29efc39 ("md/md0: optimize raid0 discard handling") Fixes: 61697a6 ("dm: eliminate 'split_discard_bios' flag from DM target interface") Cc: stable@vger.kernel.org Reported-by: Zdenek Kabelac <zkabelac@redhat.com> Reported-by: Mikulas Patocka <mpatocka@redhat.com> Signed-off-by: Mike Snitzer <snitzer@redhat.com>
1 parent cd74693 commit e0910c8

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

drivers/md/dm-raid.c

+7-5
Original file line numberDiff line numberDiff line change
@@ -3730,12 +3730,14 @@ static void raid_io_hints(struct dm_target *ti, struct queue_limits *limits)
37303730
blk_limits_io_opt(limits, chunk_size_bytes * mddev_data_stripes(rs));
37313731

37323732
/*
3733-
* RAID1 and RAID10 personalities require bio splitting,
3734-
* RAID0/4/5/6 don't and process large discard bios properly.
3733+
* RAID10 personality requires bio splitting,
3734+
* RAID0/1/4/5/6 don't and process large discard bios properly.
37353735
*/
3736-
if (rs_is_raid1(rs) || rs_is_raid10(rs)) {
3737-
limits->discard_granularity = chunk_size_bytes;
3738-
limits->max_discard_sectors = rs->md.chunk_sectors;
3736+
if (rs_is_raid10(rs)) {
3737+
limits->discard_granularity = max(chunk_size_bytes,
3738+
limits->discard_granularity);
3739+
limits->max_discard_sectors = min_not_zero(rs->md.chunk_sectors,
3740+
limits->max_discard_sectors);
37393741
}
37403742
}
37413743

0 commit comments

Comments
 (0)