Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use current! instead of bindings::get_current() in Task::pid_in_current_ns #1047

Open
y86-dev opened this issue Dec 8, 2023 · 4 comments
Open
Labels
good first issue Good for newcomers • lib Related to the `rust/` library.

Comments

@y86-dev
Copy link
Member

y86-dev commented Dec 8, 2023

The function Task::pid_in_current_ns in rust/kernel/task.rs uses bindings::get_current(). But there exists a safe abstraction for the raw binding: the current! macro. Change the implementation to use that abstraction instead.

You might also have to add a function on Task to get access to the raw C pointer.


This requires submitting a proper patch to the LKML and the Rust for Linux mailing list. Please recall to test your changes, to use a proper title for the commit, to sign your commit under the Developer's Certificate of Origin and so on. Please see https://docs.kernel.org/process/submitting-patches.html and https://rust-for-linux.com/contributing for details.

Please take this issue only if you are new to the kernel development process and you would like to use it as a test to submit your first patch to the kernel.

@y86-dev y86-dev added good first issue Good for newcomers • lib Related to the `rust/` library. labels Dec 8, 2023
@antonio-hickey
Copy link

antonio-hickey commented Jan 2, 2024

I'm not finding the function Task::pid_in_current_ns in rust/kernel/task.rs.

I see the use of bindings::get_current() in current() is this where we want to use the safe macro instead? @y86-dev

EDIT: I see now, it's in the rust-dev branch.

@antonio-hickey
Copy link

You might also have to add a function on Task to get access to the raw C pointer.

What's the reason I would or would not have to add a function to grab the raw C pointer? Any further detail on this would be appreciated, thanks.

@jsat97
Copy link

jsat97 commented Oct 24, 2024

If this is still available, may I work on it ?

@antonio-hickey
Copy link

@jsat97

I've already sent my patches

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers • lib Related to the `rust/` library.
Development

No branches or pull requests

3 participants