Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Support for Planar Sample-layouts #154

Open
rawler opened this issue Mar 10, 2021 · 3 comments
Open

Feature Request: Support for Planar Sample-layouts #154

rawler opened this issue Mar 10, 2021 · 3 comments

Comments

@rawler
Copy link
Contributor

rawler commented Mar 10, 2021

As far as I can tell, dasp::slice currently assumes Interleaved frame-layouts. (LRLRLRLRLRLRLRLR) In some cases (for example when working with FFmpeg), I get audio in Planar layout (LLLLLLLLRRRRRRRR). Currently I cannot use large parts of DASP due to this, and are instead forced to write my own functionality for iteration over sequences of Frames. It would be awesome if DASP instead could support it.

@mitchmindtree
Copy link
Member

Thanks for the issue! Totally agreed w.r.t. supporting different slice layouts.

I've never seen the term Planar used to refer to this layout before, normally just Noninterleaved. I'm curious, do you have some references for this term being used in the wild?

@rawler
Copy link
Contributor Author

rawler commented Aug 11, 2021

Planar is the term used by FFmpeg (which I'm using together with DASP). It seems to have leaked out into other products using it, like Shotcut, but also to Gstreamer and WebAudio. The term is also used in Qt, but for video.

@Be-ing
Copy link

Be-ing commented Nov 30, 2021

write my own functionality for iteration over sequences of Frames

@rawler maybe that code could be the basis for implementing this upstream?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants