Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the type of the URI constant to CStr or URI #47

Open
JOOpdenhoevel opened this issue Feb 27, 2020 · 2 comments
Open

Change the type of the URI constant to CStr or URI #47

JOOpdenhoevel opened this issue Feb 27, 2020 · 2 comments
Assignees
@JOOpdenhoevel
Labels
🦀 Blocked on Rust feature Implementing this requires Rust features that aren't stabilized yet 🌟 Ergonomics Little things that matter! Does not add functionality, but makes an API easier to use

Comments

@JOOpdenhoevel
Copy link
Contributor

This is a request from Reddit (link to comment) to change the type of the URI constant of the UriBound trait to CStr or Uri. Then, the constant would be created with the from_bytes_with_nul_unchecked function, which explicitly says that the input has to contain a null character and why this trait is unsafe to implement.

This is mostly a cosmetic change, but a good and helpful one.
@JOOpdenhoevel JOOpdenhoevel added ✨ Feature New feature or request 👋 Good First Issue An easy issue to fix for new contributors labels Feb 27, 2020
@JOOpdenhoevel JOOpdenhoevel added this to the v0.5 milestone Feb 27, 2020
@JOOpdenhoevel JOOpdenhoevel self-assigned this Feb 27, 2020
@YruamaLairba
Copy link
Contributor

i just updated to rust 1.41.1 to try and "from_bytes_with_nul_unchecked" is not yet stable as const fn.

@JOOpdenhoevel
Copy link
Contributor Author

Right, I will remove it from this milestone...

@JOOpdenhoevel JOOpdenhoevel removed this from the v0.5 milestone Mar 19, 2020
@prokopyl prokopyl added 🦀 Blocked on Rust feature Implementing this requires Rust features that aren't stabilized yet 🌟 Ergonomics Little things that matter! Does not add functionality, but makes an API easier to use and removed 👋 Good First Issue An easy issue to fix for new contributors ✨ Feature New feature or request labels Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JOOpdenhoevel JOOpdenhoevel

Labels
🦀 Blocked on Rust feature Implementing this requires Rust features that aren't stabilized yet 🌟 Ergonomics Little things that matter! Does not add functionality, but makes an API easier to use
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@prokopyl @JOOpdenhoevel @YruamaLairba