Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

decode_as argument ordering #313

Open
tarcieri opened this issue Nov 4, 2024 · 1 comment
Open

decode_as argument ordering #313

tarcieri opened this issue Nov 4, 2024 · 1 comment

Comments

@tarcieri
Copy link
Member

tarcieri commented Nov 4, 2024 •
edited
Loading

We have several decode_as methods which currently take a reader: &mut impl Reader, algorithm: Algorithm in that order. Most of these are unreleased outside of prereleases (KeypairData::decode_as is the only one in the stable public API).

I'm wondering if this ordering should be reversed so the algorithm comes first, and it reads as decode_as(algorithm, ... rather than decode_as(reader, ...

cc @baloo
@baloo
Copy link
Member

baloo commented Nov 4, 2024

I'm fine with either options

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tarcieri @baloo