fix obvious issues

Author: Harris Kaufmann

der/src/tag.rs

@@ -377,6 +377,7 @@ fn parse_parts<'a, R: Reader<'a>>(first_byte: u8, reader: &mut R) -> Result<(boo
 }
 
 impl Encode for Tag {
+    #[allow(clippy::cast_possible_truncation)]
     fn encoded_len(&self) -> Result<Length> {
         let number = self.number().value();
 
@@ -389,6 +390,7 @@ impl Encode for Tag {
         Ok(length)
     }
 
+    #[allow(clippy::cast_possible_truncation)]
     fn encode(&self, writer: &mut impl Writer) -> Result<()> {
         let mut first_byte = self.class() as u8 | u8::from(self.is_constructed()) << 5;
 

der/src/tag/number.rs

@@ -17,6 +17,7 @@ use core::fmt;
 /// encoded by using a leading tag number of 31 (`0b11111`).
 ///
 /// This library supports tag numbers with 16 bit values
+#[cfg_attr(feature = "arbitrary", derive(arbitrary::Arbitrary))]
 #[derive(Copy, Clone, Debug, Eq, Hash, PartialEq, PartialOrd, Ord)]
 pub struct TagNumber(pub u16);
 
@@ -157,16 +158,3 @@ impl fmt::Display for TagNumber {
         write!(f, "{}", self.0)
     }
 }
-
-// Implement by hand because the derive would create invalid values.
-// Use the constructor to create a valid value.
-#[cfg(feature = "arbitrary")]
-impl<'a> arbitrary::Arbitrary<'a> for TagNumber {
-    fn arbitrary(u: &mut arbitrary::Unstructured<'a>) -> arbitrary::Result<Self> {
-        Ok(Self::new(u.int_in_range(0..=Self::MAX)?))
-    }
-
-    fn size_hint(depth: usize) -> (usize, Option<usize>) {
-        u8::size_hint(depth)
-    }
-}

pkcs8/tests/encrypted_private_key.rs

@@ -4,7 +4,7 @@
 
 use der::asn1::OctetStringRef;
 use hex_literal::hex;
-use pkcs8::{pkcs5::pbes2, EncryptedPrivateKeyInfoRef};
+use pkcs8::{pkcs5::pbes2, EncryptedPrivateKeyInfoRef, PrivateKeyInfoRef};
 
 #[cfg(feature = "alloc")]
 use der::Encode;