You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I happened to have implemented a RustCrypto based suite at stevefan1999-personal/rustls-provider-rustcrypto (github.com). Although it clearly indicates that the code is a PoC, but its crude structure is already capable of running, and I have also implemented some key suites missing from the provider-example in the main rustls repo, this is also mentioned in #1.
Well, it is not because that I don't want to send a PR, but I think the intensive use of generics would make it hard to maintain (at least I think code review could be harder), yet at the same time we should NRY (not repeat yourself)...
It's quite a conflict for me over this.
The text was updated successfully, but these errors were encountered:
@stevefan1999-personal happy to go with whatever approach you prefer. You could either PR your existing code as-is, or try to break it up into a series of smaller, more incremental PRs that might be easier to review
I happened to have implemented a RustCrypto based suite at stevefan1999-personal/rustls-provider-rustcrypto (github.com). Although it clearly indicates that the code is a PoC, but its crude structure is already capable of running, and I have also implemented some key suites missing from the provider-example in the main rustls repo, this is also mentioned in #1.
Well, it is not because that I don't want to send a PR, but I think the intensive use of generics would make it hard to maintain (at least I think code review could be harder), yet at the same time we should NRY (not repeat yourself)...
It's quite a conflict for me over this.
The text was updated successfully, but these errors were encountered: