Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustls is not enabled for dependabot #80

Closed
stevefan1999-personal opened this issue Jul 6, 2024 · 3 comments
Closed

rustls is not enabled for dependabot #80

stevefan1999-personal opened this issue Jul 6, 2024 · 3 comments

Comments

@stevefan1999-personal
Copy link
Contributor

As of right now, rustls released 0.23.10 but we are still staggering in 0.23.0. Despite the API changes shouldn't be that breaking, it is always good to keep an eye out of the latest release and let CI do its thing.

@pinkforest
Copy link
Contributor

pinkforest commented Jul 6, 2024

It gets automatically 0.23.10 as it's SemVer compatible there is no need to bump given it's not pinned.

Basically any version = X.Y.Z is just "minimum" or ^ given SemVer compat range

Typically binaries only do locked builds and even then it needs to explicitly add --locked to build as non-locked is default.

Pinning libraries isn't advisable as it can cause duplicates in dep tree.

Also what comes to testing in CI - I think it would be nice to have a "cron" workflow to periodically check it as well.

But yeah dependabot pinging it always as it does and then updating the .lock as it tests them out even if not used elsewhere is the way we use it typically to ensure it works across patch releases (or minor bumps on stable vers) ....

EDIT: Oh it's been ignored for 0.23 before this was bumped:

@tarcieri
Copy link
Member

tarcieri commented Jul 7, 2024

It turns out it's hard to un-ignore a dependency with dependabot: dependabot/dependabot-core#1384

But I can try...

@tarcieri
Copy link
Member

tarcieri commented Jul 7, 2024

Okay, #82 is open, although I'm not sure why it wen to 0.23.7 instead of 0.23.10. Perhaps there's some other dependency incompatibility.

Anyway, closing this.

@tarcieri tarcieri closed this as completed Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants