New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

const default parameters also defined in `EchelleCCFs` module #60

Open

hematthi opened this issue May 27, 2022 · 0 comments

Labels

question

Collaborator

hematthi commented May 27, 2022

EchelleCCFs.jl/src/ccf/ccf.jl

Lines 1 to 6 in a639217

    
           # default parameters 
        
           const default_v_center = 0.0    # m/s 
        
           const default_v_step = 250.0    # m/s 
        
           const default_v_max = 15.0e3    # m/s 
        
           const default_v_width = 410.0   # m/s 
        
           const default_v_range_no_mask_change = default_v_max # m/s

Same parameters and values defined in EchelleCCFs.jl.
Any reason to still keep them here? This isn't a module

hematthi added the question label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment