Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ignoring patterns #123

Open
isaac-j-miller opened this issue Oct 3, 2023 · 3 comments
Open

Add support for ignoring patterns #123

isaac-j-miller opened this issue Oct 3, 2023 · 3 comments

Comments

@isaac-j-miller
Copy link

It would be nice to be able to read a list of patterns to ignore from the CLI or from a .ejslintignore file. I have a workload which runs ejs-lint on a directory containing multiple files, and the tool breaks when the directory includes a .png file, as the binary data in the file happens to contain <%, which causes ejs-lint to try to parse the following data as a scriptlet, which fails. I would be happy to create a PR to implement this

@RyanZim
Copy link
Owner

RyanZim commented Oct 3, 2023

Why can't you just pass in directory/*.ejs to exclude the .png files?

@isaac-j-miller
Copy link
Author

Not all of my template files end in .ejs. I maintain an internal templating system based on Yeoman to template out a bunch of files, and it would be cumbersome to modify Yeoman's templating to automatically rename files ending in .ejs. I use ejs-lint to validate these templates. Additionally, there are several templates which use my templating system, and I would have to update all of those as well to find every file with EJS templating in it and add the .ejs extension

@isaac-j-miller
Copy link
Author

I have created a PR here: #124

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants