Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serial bug #15

Open
ryanteck opened this issue May 5, 2016 · 1 comment
Open

Serial bug #15

ryanteck opened this issue May 5, 2016 · 1 comment
Labels

Comments

@ryanteck
Copy link
Member

ryanteck commented May 5, 2016

Serial library needs re- bundling with it instead of using host lib

@ryanteck ryanteck added the bug label May 5, 2016
@whaleygeek
Copy link
Collaborator

Make sure you leave the original LICENCE.txt in the serial folder in the bundled version, and that you leave a note in your top level licence that this bundling is done, as the licences while compatible need to be clearly marked.

The serial is bundled for convenience in deployment, I checked the pyserial licence when I embedded it upstream in the original code and it was fine to do it this way. The additional statement in the top level licence is important to keep though, otherwise you could be misunderstood as narrowing or shifting the obligations of the licence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants