-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Learning in fork #1
Comments
I thoroughly appreciate you taking the time to publish your changes, and letting me know about them. I looked through them all in great detail and I couldn't find any issues with them! The abstraction of the request handlers into the I merged your branch into a separate branch in the repository and made some minor adjustments before subsequently merging it back into the I made sure to |
Thank you for merging the commits back to your repository. The response interface-idea is derived from ASP.NET MVC, which I found work quite nicely. But I have to say I wouldn't come up with this myself to be honest. I'd like to do something equivalent with the request, but I haven't thought that through yet. This gives you the ability to switch implementation (other than Earlier I didn't notice I was deviating from the coding standards, thank you for pointing that out. |
Hey there,
I noticed your project earlier today on the Steam Workshop, which I found it quite interesting. The workshop linked to the current GitHub project. I'm trying to learn a thing or two, making commits in the fork. If you find something interesting and feel like pulling in some commits, feel free to do so. As for now there are not a lot of commits just yet, but I think that will change over time.
I hope you have a nice day,
Fe.
The text was updated successfully, but these errors were encountered: