Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Named import and ABI v2 encoder pragma #18

Closed
wants to merge 1 commit into from

Conversation

katat
Copy link

@katat katat commented Jul 12, 2019

Hello there, here are a few updates from my branch. Let me know if they look good enough to merge into the original master branch.

  • Make a fix to support named contract import
  • Strip the experimental pragma ABI encoder v2

@RyuuGan
Copy link
Owner

RyuuGan commented Jul 12, 2019

Hello @katat,

Have you seen the develop branch? Because your implementation of named imports is pretty simple, no rename support, no global rename support. And can be several pragmas on the main file?

Can you please check the develop branch, and make sure your all your needs are implemented in develop. Not sure if the experemental pragma is supported. Because soon I'll bump the version and merge develop to master. So these features will be available.

Best regards,
Valerii Aligorskii

@katat
Copy link
Author

katat commented Jul 17, 2019

Hello @RyuuGan ,

I think the renaming support in the develop branch is much better than my implementation. So I would probably use your develop branch for the named support instead. 👍

For the experimental pragma, I don't see there are any tests for that feature. So I assume it currently doesn't support this type of pragma. Will this be part of your plan for the next official release?

Best regards,
Kata

@RyuuGan
Copy link
Owner

RyuuGan commented Jul 18, 2019

Hello, @katat

Added support for experemental pragma in linked commit.

Best regards,
Valerii Aligorskii

@RyuuGan RyuuGan mentioned this pull request Jul 18, 2019
1 task
@RyuuGan RyuuGan closed this in #16 Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants