Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to webpack 5 #472

Closed
isaacabraham opened this issue Aug 20, 2021 · 3 comments
Closed

Update to webpack 5 #472

isaacabraham opened this issue Aug 20, 2021 · 3 comments

Comments

@isaacabraham
Copy link
Member

No description provided.

@theimowski
Copy link
Member

I recall there were same issues for Feliz and Webpack 5 - pmmmwh/react-refresh-webpack-plugin#330
Not sure if it relates to stuff we have in template though @Zaid-Ajaj

@mattgallagher92
Copy link
Member

Summary from a discussion between me, @theimowski and @MangelMaxime:

  • react-refresh requires that code follows certain conventions, such as not exposing types or functions that are not React components
  • Feliz code that generates JavaScript code that doesn't follow those conventions will not be able to benefit from react-refresh
  • In that case, the behaviour will be just the same as it was for webpack 4 (tab reload)

In summary, there is no problem moving to webpack 5. fulma-demo is already using webpack 5, so we can use that as a template.

@theimowski
Copy link
Member

Closed by #485

This was referenced Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants