Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: CI instability (setuptools + munch) #161

Closed
neutrinoceros opened this issue Feb 15, 2023 · 4 comments · Fixed by #163
Closed

TST: CI instability (setuptools + munch) #161

neutrinoceros opened this issue Feb 15, 2023 · 4 comments · Fixed by #163

Comments

@neutrinoceros
Copy link
Collaborator

CI is currently unstable because (see https://github.com/SAIL-Labs/AMICAL/actions/runs/4180212707)
What happens is that the newest version of setuptools (namely 67.3), which provides pkg_resources, deprecates pkg_resources.declare_namespece (see pypa/setuptools#3434), which is used by munch.

This has been a problem with munch for a while already (see Infinidat/munch#67), and it's actually been solved on the dev branch for 3 years, but the patch was never released, and now the repo looks essentially unmaintained.

I would advocate that we should try to get rid of munch as a dependency, though I may not be fully aware of what challenges this poses. TBD with @DrSoulain

@DrSoulain
Copy link
Collaborator

Indeed, munch seems to be too unstable to be used. It is only used to transform dictionary into class-like object to be easily accessible. We should be able to write a built-in dedicated function to do so.

@neutrinoceros neutrinoceros linked a pull request Feb 15, 2023 that will close this issue
@vandalt
Copy link
Contributor

vandalt commented Feb 15, 2023

In the past, I used Box for a similar purpose. It seems still well maintained: https://github.com/cdgriffith/Box.

@vandalt
Copy link
Contributor

vandalt commented Feb 15, 2023

Oops I just realized this had been closed already. Will leave the comment in case it can help someone in the future.

@neutrinoceros
Copy link
Collaborator Author

Good to know ! If we ever want to stop vendoring munch, this seems like a decent option

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants