-
-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IdPMetadataParser: unconditionally disables certificate validation for HTTPS #522
Labels
Comments
@aburch We should at least add a parameter to the parseRemoteXML method:
and then use it
Do you want to provide a PR? |
This disabling of validation is dangerous and renders this method unusable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
OneLogin_Saml2_IdPMetadataParser::parseRemoteXML
function allows to retrieve the metadata file over HTTPS.However, it unconditionally disables certificate validation:
https://github.com/onelogin/php-saml/blob/4f94a76934d9900ef0bac349182907f4b7e554ae/lib/Saml2/IdPMetadataParser.php#L40
This seems a bad choice as it bypasses the reason to use HTTPS (integrity protection).
The text was updated successfully, but these errors were encountered: