Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UriParameters is deprecated #132

Closed
o-liver opened this issue Jun 6, 2024 · 2 comments · Fixed by SAP-samples/ui5-typescript-walkthrough#14
Closed

UriParameters is deprecated #132

o-liver opened this issue Jun 6, 2024 · 2 comments · Fixed by SAP-samples/ui5-typescript-walkthrough#14
Assignees
@flovogt @KlattG
Labels
contribution Valuable Contribution type/examples-samples Related to existing examples/samples, or request for new examples/samples.

Comments

@o-liver
Copy link
Contributor

o-liver commented Jun 6, 2024 •
edited
Loading

sapui5/docs/03_Get-Started/step-26-mock-server-configuration-typescript-3e1c64f.md

Line 161 in e91c998

const uriParameters = new UriParameters(window.location.href);

Here the documentation is referring to a deprecated UriParameters function. What can be used here instead?
@KvM2
Copy link
Contributor

KvM2 commented Jun 6, 2024

Hi @o-liver, thanks for your contribution! We'll look into it and will get back to you.

@flovogt flovogt mentioned this issue Jun 12, 2024
Merged
@flovogt flovogt self-assigned this Jun 12, 2024
@KlattG
Copy link
Contributor

KlattG commented Jun 13, 2024

Fixed with UI5 1.126

@KlattG KlattG added contribution Valuable Contribution type/examples-samples Related to existing examples/samples, or request for new examples/samples. labels Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flovogt flovogt

@KlattG KlattG

Labels
contribution Valuable Contribution type/examples-samples Related to existing examples/samples, or request for new examples/samples.
Projects
None yet
Milestone
No milestone
4 participants
@o-liver @flovogt @KvM2 @KlattG