feat: 🎸 add new control ContactItem #307
Conversation
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| case email | ||
| case message | ||
| case videoCall | ||
| case detail |
There was a problem hiding this comment.
Missing Docs Violation: public declarations should be documented. (missing_docs)
| case email | ||
| case message | ||
| case videoCall |
There was a problem hiding this comment.
Missing Docs Violation: public declarations should be documented. (missing_docs)
| case email | ||
| case message |
There was a problem hiding this comment.
Missing Docs Violation: public declarations should be documented. (missing_docs)
| @@ -2,13 +2,25 @@ import SwiftUI | |||
|
|
|||
| /// :nodoc: | |||
| public enum ActivityItemType { | |||
| case phone | |||
There was a problem hiding this comment.
Missing Docs Violation: public declarations should be documented. (missing_docs)
MarcoEidinger
requested review from
billzhou0223 and
MarcoEidinger
and removed request for
dyongxu
|
@shengxu7 please fix build errors |
There was a problem hiding this comment.
@shengxu7 Can you also update the table in the readme to indicate that ContactItem is completed?
Updated. |
| descriptionText | ||
|
|
||
| Spacer(minLength: 24) | ||
| }.frame(width: mainViewSize.width * (1 - self.splitPercent!)) |
There was a problem hiding this comment.
Force Unwrapping Violation: Force unwrapping should be avoided. (force_unwrapping)
| } | ||
| .frame(width: mainViewSize.width * self.splitPercent!) |
There was a problem hiding this comment.
Force Unwrapping Violation: Force unwrapping should be avoided. (force_unwrapping)
No description provided.