-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 🎸 [JIRA-2222] Duration Picker Support #484
Conversation
91e13e0
to
2b83f2c
Compare
840457f
to
79a9061
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve the conflicts.
@@ -0,0 +1,250 @@ | |||
import SwiftUI | |||
|
|||
struct DurationPickerViewWrapper: UIViewRepresentable { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember we discussed last time to avoid using UIKit controls if possible?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried, SwiftUI Picker
can't support the spec style.
79a9061
to
25e6248
Compare
FUIDurationPickerFormCell SwiftUI migration
25e6248
to
412d34c
Compare
412d34c
to
fdbf28b
Compare
FUIDurationPickerFormCell SwiftUI migration
Public API
A minutes binding for picker selection.
Maximum minutes picker allowed, maximum is 1439.
Minimum minutes picker allowed, minimum is 0.
Interval for minutes.
Formatter for picker titles.