Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 🐛 searchable list voiceover actions failed #577

Merged
merged 4 commits into from
Jun 8, 2023
Merged

fix: 🐛 searchable list voiceover actions failed #577

merged 4 commits into from
Jun 8, 2023

Conversation

xiaoyu0722
Copy link
Contributor

No description provided.

@xiaoyu0722 xiaoyu0722 requested a review from a team as a code owner June 5, 2023 07:10
@xiaoyu0722 xiaoyu0722 requested review from billzhou0223 and removed request for a team June 5, 2023 07:10
billzhou0223
billzhou0223 requested changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@billzhou0223 billzhou0223 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean by sharedAction? In which use case this new api is needed?

billzhou0223
billzhou0223 requested changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@billzhou0223 billzhou0223 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean by sharedAction? In which use case this new api is needed?

@xiaoyu0722
Copy link
Contributor Author

sharedAction is a local action for Action that we can handle the action without tap gesture.
It can be triggered same as _didSelectAction.
Then voiceover will trigger the action.

@billzhou0223
Copy link
Contributor

sharedAction is a local action for Action that we can handle the action without tap gesture. It can be triggered same as _didSelectAction. Then voiceover will trigger the action.

I wouldn't use an environment variable for this purpose. You can add a property in Action so that is is only visible in its own scope instead of exposing it in the environment.

@xiaoyu0722
Copy link
Contributor Author

xiaoyu0722 commented Jun 7, 2023 •
edited
Loading

sharedAction is a local action for Action that we can handle the action without tap gesture. It can be triggered same as _didSelectAction. Then voiceover will trigger the action.

I wouldn't use an environment variable for this purpose. You can add a property in Action so that is is only visible in its own scope instead of exposing it in the environment.

The setting is missed, the action is actually a view wrapped in some view.

@billzhou0223 billzhou0223 merged commit 7414122 into SAP:main Jun 8, 2023
@xiaoyu0722 xiaoyu0722 deleted the fix-searchable-list-action-accessibility branch June 9, 2023 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billzhou0223 billzhou0223 billzhou0223 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xiaoyu0722 @billzhou0223 @ShadowTourist @dyongxu