fix: 🐛 [BCP:2370082757] Fix SignatureCaptureView VO issues #602
+31
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Closes: 2370082757
billzhou0223
requested changes
Oct 16, 2023
| @@ -21,6 +21,9 @@ extension Action: View { | |||
| } label: { | |||
| Text(self._actionText ?? "") | |||
| } | |||
| .accessibilityElement() | |||
There was a problem hiding this comment.
Is this modifier needed?
There was a problem hiding this comment.
Yes, it is needed. Without this line, the VO announcement is fine but double tap will not trigger action. Strange.
billzhou0223
approved these changes
Oct 16, 2023
janhuachu
added a commit
to janhuachu/cloud-sdk-ios-fiori
that referenced
this pull request
Oct 16, 2023
✅ Closes: 2370082757 (cherry picked from commit 6d09d0f)
janhuachu
added a commit
that referenced
this pull request
Oct 18, 2023
fix: 🐛 [BCP:2370082757] Fix SignatureCaptureView VO issues (#602)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Closes: 2370082757