feat: 🎸 [JIRA: HCPSDKFIORIUIKIT-1940] profile header #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
xiaoyu0722
commented
Jul 1, 2024
xiaoyu0722
commented
| static | animatable |
|---|---|
 |
 |
billzhou0223
requested changes
Jul 1, 2024
Apps/Examples/Examples/FioriSwiftUICore/ProfileHeader/ProfileHeaderAnimatableExample.swift
Outdated
Show resolved
Hide resolved
| // sourcery: @Binding | ||
| // sourcery: defaultValue = .constant(0) | ||
| /// A binding float for transition of profile header. Value should be in range of 0 to 1. Default value is 0. | ||
| var transitionProgress: CGFloat { get } |
There was a problem hiding this comment.
Is it possible to not expose progress and handle it internally in SDK? It adds additional effort to developers of using this component.
There was a problem hiding this comment.
Like swiftui-introspect to get the offset of its superview to calculate the progress?
Apps/Examples/Examples/FioriSwiftUICore/ProfileHeader/ProfileHeaderAnimatableExample.swift
Outdated
Show resolved
Hide resolved
dyongxu
reviewed
Jul 1, 2024
dyongxu
requested changes
Jul 1, 2024
dyongxu
approved these changes
Jul 3, 2024
|
@xiaoyu0722 Looks like some other PR has checked in some generated files, causing your merge conflict. Need to pull latest main to resolve conflict. |
xiaoyu0722
force-pushed
the
feat-profile-header
branch
from
8d84870
to
cec4453
Compare
|
Hi @billzhou0223 , need review again. |
billzhou0223
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.