add waterfall chart #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoEidinger
requested changes
Jun 30, 2020
There was a problem hiding this comment.
Hi, in addition to my comments (please review) I'd like to ask you to add an entry related to waterfall chart in FioriChartsLibraryContent.swift
FYI developing and pushing changes from a fork's master branch is not best practise. Apparently you have not proper synced and therefore previous commits are listed in this PR and rebase is not possible. This PR can still be merged via a merge request. For the future I recommend to get used to develop on a feature branch and keep your fork up-to-date with base repository. For any questions please reach out to me.
Sources/FioriCharts/Charts/WaterfallChart/WaterfallConnectingLinesView.swift
Outdated
Show resolved
Hide resolved
Sources/FioriCharts/Charts/WaterfallChart/WaterfallIndicatorView.swift
Outdated
Show resolved
Hide resolved
Sources/FioriCharts/Charts/WaterfallChart/WaterfallSeriesView.swift
Outdated
Show resolved
Hide resolved
MarcoEidinger
requested changes
Jun 30, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.