Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 🐛 step progress indicator styles #775

Merged
merged 1 commit into from
Aug 15, 2024
Merged

fix: 🐛 step progress indicator styles #775

merged 1 commit into from
Aug 15, 2024

Conversation

xiaoyu0722
Copy link
Contributor

  • The font color in a complete step should be in #FFFFFF (Quinary label)
  • Use Fiori icon in the header for disclosure control (“>”):
    • Fiori icon: fiori.slim.arrow.right
    • Color: Separator
    • Size: 16pt
  • Title in the header should use Headline Semi-bold (17pt)
  • Right accessory in the header are not switched to dark mode colors

@xiaoyu0722 xiaoyu0722 requested a review from a team as a code owner August 15, 2024 08:39
@xiaoyu0722 xiaoyu0722 requested review from billzhou0223 and removed request for a team August 15, 2024 08:39
@billzhou0223 billzhou0223 merged commit 01b43e4 into SAP:main Aug 15, 2024
12 checks passed
dyongxu added a commit that referenced this pull request Aug 16, 2024
@dyongxu @MarcoEidinger
@billzhou0223 @xiaoyu0722 @hengyi-zhang @service-tip-git
merge: from main to rel-4.1 to get the latest translation package and…
fcbf54f 
… other fixes (#776)

* chore(release): 4.1.2

* fix: 🐛 [IOSSDKBUG-291] set line limit for MenuSelectionItem (#769)

* fix: 🐛 [JIRA: IOSSDKBUG-306] toolbar layout issue (#771)

* feat: 🎸 [JIRA:HCPSDKFIORIUIKIT-2686] Button update (#753)

Co-authored-by: Bill Zhou <bill.zhou01@sap.com>

* fix: 🐛 step progress indicator styles (#775)

* Translation Delivery (#774)

* [INTERNAL] Translation delivery: commit by LX Lab

Change-Id: I111a249ae01afea6ba8029630027e1807e471499

* [INTERNAL] Translation delivery: commit by LX Lab

Change-Id: I00c59b0e7a3bcd6346b6fddb8a51787bc132ace4

---------

Co-authored-by: dyongxu <61523257+dyongxu@users.noreply.github.com>

---------

Co-authored-by: Marco Eidinger <marco.eidinger@sap.com>
Co-authored-by: Bill Zhou <bill.zhou01@sap.com>
Co-authored-by: Xiaoyu Liu <xiaoyuliu0722@gmail.com>
Co-authored-by: hengyi-zhang <hengyizhangcn@gmail.com>
Co-authored-by: SAP LX Lab Service Account <tmsatsls+github.com_service-tip-git@sap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billzhou0223 billzhou0223 billzhou0223 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xiaoyu0722 @billzhou0223